Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --report-unsupported-elements-at-runtime from native-image.properties #2368

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Remove --report-unsupported-elements-at-runtime from native-image.properties #2368

merged 1 commit into from
Apr 2, 2021

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Apr 2, 2021 •
edited
Loading

Description

Removes --report-unsupported-elements-at-runtime from native-image.properties

Motivation and Context

As described in oracle/graal#1725 (comment) this option is not meant to be used in production and under certain circumstances it may cause oracle/graal#1725 to appear as in quarkusio/quarkus#16139.

cc @zoewangg

Testing

Tested with:

mvn clean install -pl :sdk-native-image-test -P quick --am
mvn clean install -pl :bom-internal,:bom
cd test/sdk-native-image-test
export JAVA_HOME=/opt/jvms/graalvm-ce-java11-21.0.0
mvn clean package -P native-image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zakkak zakkak mentioned this pull request Apr 2, 2021
Closed
zoewangg
zoewangg reviewed Apr 2, 2021
View reviewed changes
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR! Could you add a changelog entry? You can generate one by running scripts/new-change script and following the instructions. Make sure you squash commits into one.

@zakkak
Remove --report-unsupported-elements-at-runtime
0abf510 
As described in
oracle/graal#1725 (comment)
this option is not meant to be used in production and under certain
circumstances it may cause oracle/graal#1725
to appear as in quarkusio/quarkus#16139.
@zakkak zakkak force-pushed the rm-report-unsupported-elements-at-runtime branch from bf2da2a to 0abf510 Compare April 2, 2021 00:56
@zakkak
Copy link
Contributor Author

zakkak commented Apr 2, 2021 •
edited
Loading

Thanks for the prompt reply @zoewangg. I added the changelog entry :)

@sonarcloud
Copy link

sonarcloud bot commented Apr 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zoewangg
Copy link
Contributor

zoewangg commented Apr 2, 2021

Thank you for your contribution! :) This change will be included in the next release.

@zoewangg zoewangg merged commit b1593b1 into aws:master Apr 2, 2021
@zakkak zakkak deleted the rm-report-unsupported-elements-at-runtime branch April 2, 2021 10:20
@zakkak zakkak mentioned this pull request Apr 6, 2021
Merged
@Sanne Sanne mentioned this pull request May 19, 2021
Closed
@JiriOndrusek JiriOndrusek mentioned this pull request Jan 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoewangg zoewangg zoewangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zakkak @zoewangg